guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

04/07: build: install: Do not set store GID.


From: guix-commits
Subject: 04/07: build: install: Do not set store GID.
Date: Tue, 5 May 2020 10:14:37 -0400 (EDT)

mothacehe pushed a commit to branch master
in repository guix.

commit 892bbea750e5733979ee0423cbdfcea222b07925
Author: Mathieu Othacehe <address@hidden>
AuthorDate: Tue May 5 14:26:35 2020 +0200

    build: install: Do not set store GID.
    
    There's no need to set the store GID as is will be done by the guix-daemon,
    with the following snippet:
    
      if (chown(chrootStoreDir.c_str(), 0, buildUser.getGID()) == -1)
            throw SysError(format("cannot change ownership of ‘%1%’") % 
chrootStoreDir);
    
    * gnu/build/install.scm (directives): Do not set store GID.
---
 gnu/build/install.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/build/install.scm b/gnu/build/install.scm
index 9753792..59a118e 100644
--- a/gnu/build/install.scm
+++ b/gnu/build/install.scm
@@ -101,9 +101,7 @@ the context of the caller.  If the directive matches those 
defaults then,
 (define (directives store)
   "Return a list of directives to populate the root file system that will host
 STORE."
-  `(;; Note: the store's GID is fixed precisely so we can set it here rather
-    ;; than at activation time.
-    (directory ,store 0 30000 #o1775)
+  `((directory ,store 0 0 #o1775)
 
     (directory "/etc")
     (directory "/var/log")                          ; for shepherd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]