guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/01: gnu: guile-hall: Update to 0.2.


From: Ricardo Wurmus
Subject: Re: 01/01: gnu: guile-hall: Update to 0.2.
Date: Fri, 15 Feb 2019 21:12:10 +0100
User-agent: mu4e 1.0; emacs 26.1

Hi Alex,

> You're right, this is incorrect.  One of the points of Hall is to
> generate reproducible guix packages ā€” but currently they default to
> using (guix licenses) without prefix.  The generated recipe hence has no
> prefix. I will fix this.

Oh, I see.  I did not immediately realize that this was a generated
recipe.

> Again, this is the result of auto-generation: Hall generically wraps any
> script files in the scripts directory of a project with all Guile
> dependencies ā€” rather than the developer having to manually specify
> these things.

I think this should rather be done by the guile-build-system.  We
already do this in other build systems such as python-build-system.

> - hiding the complexity inside a build system for Guix, which carries
>   out the steps currently added by Hall explicitly.

This seems to be the best way forward.

> I can also see that you have fixed my commit and tweaked it in several
> ways ā€” thank you for doing this.
>
> Are the steps you carried out "the recommended way" of doing things now?
> If so then I can adapt hall to default to this workflow, so we can
> encourage new contributors to do "the right thing".

I had a few more changes that I intended to push but then stopped to
write you.  In the case of guile-hall I think the wrapping could be
greatly simplified, but that would not necessarily be possible in the
generic case.  If we add this behaviour to the guile-build-system,
however, Hall would not have to do any of this and the package
definition could become simpler.

Iā€™m excited about Hall and would love to add support for it in Guile
Studio (e.g. through a menu in the menu bar).

--
Ricardo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]