guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

06/10: gnu: grep: Work around test failure with glibc 2.28.


From: Marius Bakke
Subject: 06/10: gnu: grep: Work around test failure with glibc 2.28.
Date: Sat, 25 Aug 2018 10:30:53 -0400 (EDT)

mbakke pushed a commit to branch core-updates
in repository guix.

commit 8c8ded2cc9201e69e87999bb40ef09c6c868deb8
Author: Marius Bakke <address@hidden>
Date:   Fri Aug 24 16:37:50 2018 +0200

    gnu: grep: Work around test failure with glibc 2.28.
    
    * gnu/packages/base.scm (grep)[arguments]: Add phase 
'disable-failing-tests'.
---
 gnu/packages/base.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 114413b..1c652bc 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -102,6 +102,15 @@ command-line arguments, multiple languages, and so on.")
    (arguments
     `(#:phases
       (modify-phases %standard-phases
+        (add-before 'check 'disable-failing-tests
+          (lambda _
+            ;; These tests are expected to fail due to a glibc bug which has
+            ;; been fixed in 2.28, so they are unexpectedly passing.  They
+            ;; should be fixed for grep versions > 3.1.
+            (substitute* "tests/Makefile.in"
+              (("^[[:blank:]]+backref-alt[[:blank:]]+\\\\") "\\")
+              (("^[[:blank:]]+triple-backref[[:blank:]]+\\\\") "\\"))
+            #t))
         (add-after 'install 'fix-egrep-and-fgrep
           ;; Patch 'egrep' and 'fgrep' to execute 'grep' via its
           ;; absolute file name instead of searching for it in $PATH.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]