[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
54/118: build-remote.pl: Don't keep a shell process around
From: |
Ludovic Courtès |
Subject: |
54/118: build-remote.pl: Don't keep a shell process around |
Date: |
Tue, 19 May 2015 14:45:37 +0000 |
civodul pushed a commit to branch nix
in repository guix.
commit b2e0293f022123b11759dfd498d4eff72233d3f7
Author: Eelco Dolstra <address@hidden>
Date: Sat Jul 12 00:43:28 2014 +0200
build-remote.pl: Don't keep a shell process around
---
perl/lib/Nix/SSH.pm | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/perl/lib/Nix/SSH.pm b/perl/lib/Nix/SSH.pm
index 84bff5c..3bcbabe 100644
--- a/perl/lib/Nix/SSH.pm
+++ b/perl/lib/Nix/SSH.pm
@@ -113,7 +113,8 @@ sub connectToRemoteNix {
# Start ‘nix-store --serve’ on the remote host.
my ($from, $to);
- my $pid = open2($from, $to, "ssh $sshHost @{$sshOpts} nix-store --serve
--write $extraFlags");
+ # FIXME: don't start a shell, start ssh directly.
+ my $pid = open2($from, $to, "exec ssh $sshHost @{$sshOpts} nix-store
--serve --write $extraFlags");
# Do the handshake.
my $SERVE_MAGIC_1 = 0x390c9deb; # FIXME
- 43/118: Remove tabs, (continued)
- 43/118: Remove tabs, Ludovic Courtès, 2015/05/19
- 35/118: Don't build on Ubuntu 10.10, Ludovic Courtès, 2015/05/19
- 44/118: nix-copy-closure: Fix --dry-run, Ludovic Courtès, 2015/05/19
- 47/118: Replace message "importing path <...>" with "exporting path <...>", Ludovic Courtès, 2015/05/19
- 37/118: Add a test for the SSH substituter, Ludovic Courtès, 2015/05/19
- 39/118: nix-copy-closure: Fix race condition, Ludovic Courtès, 2015/05/19
- 49/118: Allow $NIX_BUILD_HOOK to be relative to Nix libexec directory, Ludovic Courtès, 2015/05/19
- 52/118: Fix test, Ludovic Courtès, 2015/05/19
- 42/118: Refactoring: Move all fork handling into a higher-order function, Ludovic Courtès, 2015/05/19
- 41/118: nix-copy-closure: Restore compression and the progress viewer, Ludovic Courtès, 2015/05/19
- 54/118: build-remote.pl: Don't keep a shell process around,
Ludovic Courtès <=
- 57/118: Manual: Typo, Ludovic Courtès, 2015/05/19
- 53/118: build-remote.pl: Fix build log, Ludovic Courtès, 2015/05/19
- 66/118: nix-daemon: Show name of connecting user, Ludovic Courtès, 2015/05/19
- 58/118: Pass *_proxy vars to bootstrap fetchurl, Ludovic Courtès, 2015/05/19
- 56/118: Remove cruft, Ludovic Courtès, 2015/05/19
- 48/118: Fix broken Pid constructor, Ludovic Courtès, 2015/05/19
- 51/118: build-remote.pl: Use ‘nix-store --serve’ on the remote side, Ludovic Courtès, 2015/05/19
- 62/118: Be more strict about file names in NARs, Ludovic Courtès, 2015/05/19
- 65/118: nix-daemon: Only print connection info if we have SO_PEERCRED, Ludovic Courtès, 2015/05/19
- 72/118: Remove dead code, Ludovic Courtès, 2015/05/19