[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1-3/3] Emacsy, mru-next and next-buffer have opp semantics
From: |
Jan Nieuwenhuizen |
Subject: |
Re: [PATCH 1-3/3] Emacsy, mru-next and next-buffer have opp semantics |
Date: |
Sun, 23 Jun 2019 22:35:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Amar Singh writes:
> A. Patch: swap prev-buffer <--> next-buffer
> Steps to reproduce issue:
>
> ;; 1. load emacsy buffers without the fix.
> (load "buffer.scm")
>
> ;; 2. imagine these are tabs opened in order
> (map add-buffer! '(peace satan hell))
>
> ;; 3. manually verify that we have these buffers
> (buffer-list) ;; (hell satan peace)
>
> ;; 4. current buffer should be 'hell
> (current-buffer) ;; -> hell
> (prev-buffer) ;; -> peace
> (next-buffer) ;; -> satan
That's nice, we may consider adding this into a test -- this email will
be forgotten.
Applied, thank!
> prev-buffer has next-buffer semantics and vice versa, due to what
> mru-next! considers next.
Good.
> B. Patch: add procedures buffer-next! buffer-prev!
>
> Also, the procedures buffer-next! and buffer-previous! have been added
> so that these can be used from a repl without the emacsy gui running.
Nice, applied.
> C. Patch: use #:export form instead of define*-public forms
> Have the API in one place at the top of the file
Applied, thank.
Greetings,
janneke
--
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | AvatarĀ® http://AvatarAcademy.com