[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Emacsy buffer.scm: remove other-buffer, rename next-buffer t
|
From: |
Jan Nieuwenhuizen |
|
Subject: |
Re: [PATCH] Emacsy buffer.scm: remove other-buffer, rename next-buffer to other-buffer --text follows this line- |
|
Date: |
Sun, 23 Jun 2019 20:17:56 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Amar Singh writes:
Hi!
Thank for the patch.
> -(define-interactive (next-buffer #:optional (incr 1))
> +(define-interactive (other-buffer #:optional (incr 1))
> (mru-next! buffer-stack incr)
> (switch-to-buffer (mru-ref buffer-stack)))
This needs more thought. Although I observed this behaviour, I had a
look at test/mru-stack.scm; that seems to assert `next-buffer' is OK.
So, hmm? I'm guessing that something else is going on and this function
is fine after all. In any case, let's write a failing test first.
> -;;.
> -(define-interactive (other-buffer #:optional (count 1))
> - (next-buffer count))
> -
Also, we really want to provide other-buffer *and* next buffer; they
need to work of course.
janneke
--
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com