Re: [PATCH] Enable utf8->string to take a range

[Maxime Devos]

Vijay Marupudi schreef op do 20-01-2022 om 22:23 [-0500]:
> +      c_start = scm_to_size_t (start);
> +      if (SCM_UNLIKELY (c_start >= c_len))
> +        {
> +          scm_out_of_range (FUNC_NAME, start);
> +        }
> +
> +      if (!scm_is_eq (end, SCM_UNDEFINED))
> +     {
> +       c_end = scm_to_size_t (end);
> +       if (SCM_UNLIKELY (c_end > c_len))
> +         scm_out_of_range (FUNC_NAME, end);

IIUC, this will cause an out-of-range error for the following:

(utf8->string "" 0 0)

However, the following works:

(substring "" 0 0) ; -> empty string

There seems to be an inconsistency here.  Can (c_start >= c_len) be
relaxed to c_start > c_len?

Greetings,
Maxime.

signature.asc
Description: This is a digitally signed message part