guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Support HTTP/2 in HTTP client


From: Derek Upham
Subject: Re: [Patch] Support HTTP/2 in HTTP client
Date: Wed, 1 Apr 2020 03:21:59 +0200 (CEST)
User-agent: mu4e 1.3.2; emacs 28.0.50

I made this particular tweak because Guile 2.2’s HTTP/1.1 client requests were getting back an HTTP/2 response from a podcast server, and choking. (The use of Google’s URL was just an example to show the format of the HTTP response header.) Let’s drop the patch for now. I’ll try disabling it locally and see whether I can still reproduce it. Given the amount of redirects that media website backends do, it’s possible that I’ll never come across the problem again.

Derek

Tristan Colgate <address@hidden> writes:

http/2 is a substantially different protocol, it will take
considerable effort to support it, guile's client should only be
offering http/1.1 to the server.

On Tue, 31 Mar 2020 at 15:49, Derek Upham <address@hidden> wrote:

Companies like Google now respond to HTTP requests with HTTP 2.
For example:

  curl --silent --head https://www.google.com

returns the first line

  HTTP/2 200

The Guile HTTP client code expects a “HTTP/x.y” structure, and
treats this as an error.  This patch recognizes and handles
“HTTP/2” on input and output.  HTTP version numbers don’t
proliferate quickly, so the code uses a brute force approach for
now.


Derek

--
Derek Upham
address@hidden


--
Derek Upham
address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]