Re: [PATCH] fix incorrect documentation for coverage-data->lcov

[Timothy Sample]

Hi Peter,

Peter Elliott <address@hidden> writes:

> Hello,
> coverage-data->lcov does not, and never has taken a 'modules'
> argument, so I've removed it.
> However, I would really like this, and might add it if it's not too hard.

I submitted a patch for this a little while ago:

    https://lists.gnu.org/archive/html/guile-devel/2017-12/msg00006.html

My knowledge of the Guile internals was and is pretty limited, but the
patch worked for my purposes.  Maybe it would be useful to you, too.

The only part that is weird in my patch (in retrospect) is that the
“modules” parameter is a list of filenames.  The name doesn’t really
make the parameter type clear (it could be a list of modules objects or
a list of modules like you pass to “use-modules”).

I used it by filtering the results of “instrumented-source-files”:

    (let ((modules (filter project-file?
                           (instrumented-source-files data))))
      (coverage-data->lcov data port #:modules modules))

where “project-file?” tests if a file is part of the current project (as
opposed to part of Guile or another library).

Hope that helps!


-- Tim