guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTE


From: Freja Nordsiek
Subject: Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file
Date: Wed, 15 Mar 2017 08:49:39 +0100

Those changes look fine. More clear now.


Freja Nordsiek

On Mar 15, 2017 8:46 AM, "Andy Wingo" <address@hidden> wrote:
On Tue 14 Mar 2017 20:41, Freja Nordsiek <address@hidden> writes:

> I missed adding an entry for meta/guile-2.2.pc.in in the commit log. Fixed now.

Applied, thanks!

Note that I made a small change to the commit log:

> Subject: [PATCH] GUILE_SITE_DIR: updated to find compiled site directories
>
> * meta/guile.m4: GUILE_SITE_DIR updated to find compiled site directories
> * meta/guile-2.2.pc.in: added entry for site-ccache directory

GUILE_SITE_DIR: Update to find compiled site directories

* meta/guile.m4 (GUILE_SITE_DIR): Update to find compiled site
  directories.
* meta/guile-2.2.pc.in: Add entry for site-ccache directory.

Here we usually avoid going over 72 columns (because these logs are
often indented, e.g. via "git log") and the general tone is a bit more
declarative, in the present tense, and with full stops.

Andy

reply via email to

[Prev in Thread] Current Thread [Next in Thread]