guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Windows file name separators


From: Eli Zaretskii
Subject: Re: Windows file name separators
Date: Thu, 03 Jul 2014 21:09:08 +0300

> From: address@hidden (Ludovic Courtès)
> Cc: address@hidden
> Date: Thu, 03 Jul 2014 19:11:41 +0200
> 
> > Is the below OK?
> 
> Looks good to me, OK to push.

Done.

> > --- test-suite/tests/ports.test~2   2014-06-29 16:06:51 +0300
> > +++ test-suite/tests/ports.test     2014-07-03 10:55:30 +0300
> > @@ -1866,6 +1865,17 @@
> >      (with-fluids ((%file-port-name-canonicalization 'absolute))
> >        (port-filename (open-input-file (%search-load-path 
> > "ice-9/q.scm"))))))
> >  
> > +(with-test-prefix "file name separators"
> > +
> > +  (pass-if "no backslash separators in Windows file names"
> > +    ;; In Guile 2.0.11 and earlier, %load-path on Windows could
> > +    ;; include file names with backslashes, and `getcwd' on Windows
> > +    ;; would always return a directory name with backslashes.
> > +    (or (not (file-name-separator? #\\))
> > +   (with-load-path (cons (getcwd) %load-path)
> > +     (not (string-index (%search-load-path (basename (test-file)))
> > +                        #\\))))))
> 
> No tabs in Scheme files please (if you use Emacs, there’s a
> .dir-locals.el that should set it up correctly.)

.dir-locals don't affect patch application by Patch.

Btw, there are quite a few *.test files with tabs.  I untabified the
ones I modified recently (even if tabs were in places I didn't
modify), but there are more left.  JFYI.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]