guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Don't skip popen.test on MinGW


From: Eli Zaretskii
Subject: Re: Don't skip popen.test on MinGW
Date: Mon, 30 Jun 2014 17:51:29 +0300

> From: address@hidden (Ludovic Courtès)
> Cc: Mark H Weaver <address@hidden>,  address@hidden
> Date: Mon, 30 Jun 2014 13:10:18 +0200
> 
> Eli Zaretskii <address@hidden> skribis:
> 
> > Another issue related to open-process is that popen.test was being
> > skipped because if-supported returns #f.  I fixed it thusly:
> >
> >      (define-syntax-rule (if-supported body ...)
> >        (if (or (provided? 'fork)
> >            ((string-contains %host-type "-mingw32")))
> >        (begin body ...)))
> >
> > Is this OK?  Again, perhaps the test should be removed, and popen.test
> > should be run unconditionally?
> 
> ‘if-supported’ was also added when addressing MinGW issues as part of
> <http://bugs.gnu.org/13848>.
> 
> For now I think it’s best to change it to:
> 
>   (define-syntax-rule (if-supported body ...)
>     (begin body ...))

Will do that as well, thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]