guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/6] split linker out of elf module


From: Ludovic Courtès
Subject: Re: [PATCH 1/6] split linker out of elf module
Date: Wed, 22 May 2013 22:39:17 +0200
User-agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux)

Hello!

Note: I’m just familiarizing with the new code, so I may miss things,
and may make mostly superficial comments.

Andy Wingo <address@hidden> skribis:

> * module/Makefile.am:
> * module/system/vm/linker.scm: New file, split out of (system vm elf).
>
> * module/system/vm/elf.scm: Remove linking capabilities.
>
> * module/language/objcode/elf.scm: Adapt caller to use (system vm
>   linker).
>
> * test-suite/tests/linker.test: New test.

Looks good.  Would be nice to mention variable names too.

It seems elf.scm would benefit from byte structures similar to those
announced by Taylan on guile-user.  That’s more for aesthetics though,
and definitely not blocking.

Docstrings are lacking in those files.

Ludo’.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]