[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] split linker out of elf module
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/6] split linker out of elf module |
Date: |
Wed, 22 May 2013 22:39:17 +0200 |
User-agent: |
Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) |
Hello!
Note: I’m just familiarizing with the new code, so I may miss things,
and may make mostly superficial comments.
Andy Wingo <address@hidden> skribis:
> * module/Makefile.am:
> * module/system/vm/linker.scm: New file, split out of (system vm elf).
>
> * module/system/vm/elf.scm: Remove linking capabilities.
>
> * module/language/objcode/elf.scm: Adapt caller to use (system vm
> linker).
>
> * test-suite/tests/linker.test: New test.
Looks good. Would be nice to mention variable names too.
It seems elf.scm would benefit from byte structures similar to those
announced by Taylan on guile-user. That’s more for aesthetics though,
and definitely not blocking.
Docstrings are lacking in those files.
Ludo’.
- Re: [PATCH 5/6] refactor and simplify ELF loader in objcodes.c, (continued)
[PATCH 3/6] elf: add accessors for header members that might need relocation, Andy Wingo, 2013/05/18
[PATCH 4/6] refactor linker to lay out ELF files and memory in the same way, Andy Wingo, 2013/05/18
[PATCH 1/6] split linker out of elf module, Andy Wingo, 2013/05/18
- Re: [PATCH 1/6] split linker out of elf module,
Ludovic Courtès <=
Re: wip-linker: Refactor ELF linker and loader, Ludovic Courtès, 2013/05/22