guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve handling of Unicode byte-order marks (BOMs)


From: Ludovic Courtès
Subject: Re: [PATCH] Improve handling of Unicode byte-order marks (BOMs)
Date: Fri, 05 Apr 2013 12:04:00 +0200
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.3 (gnu/linux)

Mike Gran <address@hidden> skribis:

>>>>  +      /* If the specified encoding is UTF-16 or UTF-32, then make
>>>>  +         that more precise by deciding what endianness to use.  */
>>>>  +      if (strcasecmp (pt->encoding, "UTF-16") == 0)
>>>>  +        precise_encoding = decide_utf16_encoding (port, mode);
>>>>  +      else if (strcasecmp (pt->encoding, "UTF-32") == 0)
>>>>  +        precise_encoding = decide_utf32_encoding (port, mode);
>>> 
>>>  Ideally these comparisons would not be locale-dependent.  Dunno.
>> 
>> Yes, that would be preferable.  We talked about adding an
>> 'ascii_strcasecmp' function.  What file do you think it should be
>> defined in?
>
> It would be a trivial function to write, of course, but there is a
> c-strcasecmp func in gnulib.

Yes, better use that one.

(Just add ‘c-strcase’ in m4/gnulib-cache.m4, run ‘gnulib-tool --update’
with Gnulib v0.0-7865-ga828bb2, and git add the new files.)

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]