Re: [PATCH] Add internal-only port structure; move iconv descriptors there

[Andy Wingo]

LGTM if these are addressed:

On Sun 31 Mar 2013 09:52, Mark H Weaver <address@hidden> writes:

> +#define SCM_INTERNAL_PTAB_ENTRY(x)                              \
> +  ((scm_t_port_internal *) (SCM_PTAB_ENTRY(x)->input_cd))
> +

SCM_PORT_GET_INTERNAL(x) ?  PTAB is a historical name (port table; there
is no more port table.)

>    SCM z = scm_cons (SCM_EOL, SCM_EOL);
> -  scm_t_port *entry = (scm_t_port *) scm_gc_calloc (sizeof (scm_t_port), 
> "port");
> +  scm_t_port *entry = scm_gc_typed_calloc (scm_t_port);
> +  scm_t_port_internal *pti = scm_gc_typed_calloc (scm_t_port_internal);
>    const char *enc;

How about allocating a struct { scm_t_port a; scm_t_port_internal b; }
and get the pointers from there?

Andy
-- 
http://wingolog.org/