guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Bindings for ‘sendfile’


From: Mark H Weaver
Subject: Re: [PATCH] Bindings for ‘sendfile’
Date: Fri, 22 Mar 2013 15:22:19 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Mark H Weaver <address@hidden> skribis:
>
>> Since the code below will behave badly if 'c_count' does not fit in an
>> 'ssize_t', we should validate here that it _does_ fit.
>
> Oops, indeed.  (Note that sendfile(2) and write(2) have that problem:
> they take a size_t and return a ssize_t...)
>
> There was also the other issue of making sure we use the right function,
> depending on _FILE_OFFSET_BITS & co.
>
> Here are the changes compared to the previous patch:

[...]

> WDYT?

Looks good to me! :)

    Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]