Re: byte-order marks

[Ludovic Courtès]

Hello!

Andy Wingo <address@hidden> skribis:

> On Tue 29 Jan 2013 18:09, Mark H Weaver <address@hidden> writes:

[...]

>> However, 'open-input-file' should not auto-detect the encoding by
>> default,
>
> The ball is in your court now :)

Can we discuss this one in the other thread, so my little brain and
mailbox don’t get confused?  :-)

> From 5512fe4f93e4e583ab538ae02dd98e5825252dc9 Mon Sep 17 00:00:00 2001
> From: Andy Wingo <address@hidden>
> Date: Wed, 30 Jan 2013 10:17:25 +0100
> Subject: [PATCH] detect and consume byte-order marks for textual ports
>
> * libguile/ports.h:
> * libguile/ports.c (scm_consume_byte_order_mark): New procedure.
>
> * libguile/fports.c (scm_open_file): Call consume-byte-order-mark if we
>   are opening a file in "r" mode.
>
> * libguile/read.c (scm_i_scan_for_encoding): Don't do anything about
>   byte-order marks.
>
> * libguile/load.c (scm_primitive_load): Add a note about the duplicate
>   encoding scan.
>
> * test-suite/tests/filesys.test: Add tests for UTF-8, UTF-16BE, and
>   UTF-16LE BOM handling.

Looks good to me.

Thanks!

Ludo’.