guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add new read-delimited option to return #f while terminating


From: Nala Ginrut
Subject: Re: [PATCH] add new read-delimited option to return #f while terminating delimiter can't be found.
Date: Wed, 23 Jan 2013 00:41:04 +0800

done.
With little modify:
1. test-case/tests/rdelim.test:  change 'delimiter fail, fail' to 'delimiter miss, fail'
2. doc/ref/api-io.texi: Sentence fix.

Thanks!


On Tue, Jan 22, 2013 at 8:44 PM, Andy Wingo <address@hidden> wrote:
On Thu 17 Jan 2013 10:07, Nala Ginrut <address@hidden> writes:

> On Wed, 2013-01-16 at 18:42 +0100, Andy Wingo wrote:
>> On Wed 07 Mar 2012 17:32, Nala Ginrut <address@hidden> writes:
>>
>> > (call-with-input-string "asdf" (lambda (port) (read-delimited "@" port
>> > 'fail))))
>>
>> LGTM; just missing a test case.  I would tighten up the documentation,
>> too: make sure each sentence is actually a sentence.  (It's a common
>> mistake, even for native speakers.)
>>
>
> Attached the patch for rdelim test case. Please review it.

Looks fine to me.  Please submit one patch with the change, the test
case, and the doc all in one.  Thanks :)

Andy
--
http://wingolog.org/

Attachment: 0001-Add-fail-mode-to-read-delimited.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]