guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH


From: Ludovic Courtès
Subject: Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al
Date: Thu, 29 Nov 2012 11:27:07 +0100
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux)

Hi Mark!

Mark H Weaver <address@hidden> skribis:

> Hi Ludovic,
>
> address@hidden (Ludovic Courtès) writes:
>> Mark H Weaver <address@hidden> skribis:
>>
>>> +#define FUNC_NAME s_scm_parse_path_with_ellipsis
>>> +{
>>> +  SCM ellipsis = scm_from_latin1_string ("...");
>>
>> Use ‘SCM_SYMBOL’ instead.
>
> It's a string, not a symbol.

Oops, right.  Then there’s SCM_IMMUTABLE_STRING.  :-)

> I've attached a revised patch that also does a much better job of
> updating the docs.  I also noticed that the documentation of the default
> load path did not match reality.

Excellent, looks great to me.

If everything goes well, we may be able to tag tonight.  WDYT?

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]