guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Preserve keyword in 'syntax-rules' and 'define-syntax-rule'


From: Mark H Weaver
Subject: Re: [PATCH] Preserve keyword in 'syntax-rules' and 'define-syntax-rule'
Date: Wed, 10 Oct 2012 19:34:55 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Mark H Weaver <address@hidden> skribis:
>
>> Unfortunately, preserving the macro keyword breaks one of Oleg
>> Kiselyov's macros, namely 'ppat' in system/base/pmatch.scm:
>
> [...]
>
>> Oleg's macro uses '_' in the keyword position of the pattern, even
>> though '_' is in the literals list.  Therefore, it fails to match
>> because 'ppat' does not match that literal.
>
> I would call it a bug in ‘ppat’.  However, the real question is how
> frequent that “bug” is.  If people have come to rely on the current
> behavior, then it may be more reasonable to stick to it.

I tend to agree that it's arguably a bug in 'ppat'.  I could go either
way on this, so I'll leave it up to you and Andy.

>> Among other things,
>
> What were the other things?  :-)

Well, anything that uses pmatch will fail.  I'm not aware of any other
problems.

     Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]