guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] read-response-body should return received data when error oc


From: Daniel Hartwig
Subject: Re: [PATCH] read-response-body should return received data when error occcurs (V2)
Date: Fri, 16 Mar 2012 15:32:13 +0800

On 16 March 2012 13:54, Nala Ginrut <address@hidden> wrote:
> This patch will return any data get-bytevector-n received and throw error
> when get <eof>.
> Actually, it's not the same feature in the old version thread
> http://lists.gnu.org/archive/html/guile-devel/2012-03/msg00116.html
> The old version is complicated because it catches *any* exception and return
> the received data within exception.
> But this new version is an easy one.

Yes, it looks much nicer :-)

> My point is, read-response-body is a low level procedure, so we shouldn't
> make it complex. But our current doesn't return received data when
> the received data is less than the content-length. I think it should return
> it, and let the user  determine whether it's an error or continue reading.

So r-r-b is a really a two-liner:

- read response body from port;
- make sure the complete response has been read.

This combination is the utility of the procedure: it guarentees that
the data it returns comprises the complete response body.

With your proposed change, that guarentee no longer holds.  The caller
now must perform their own checks on the response data size, making
your function effectively this:

- read response body data from port.

So what is the utility of calling a procedure to do that over, say,
reading from the port directly? [pointed out earlier in this thread]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]