Re: [Guile-commits] GNU Guile branch, master, updated. v2.1.0-68-g79eb47e

[Ludovic Courtès]

Hi,

Andy Wingo <address@hidden> skribis:

> On Sun 26 Feb 2012 22:38, address@hidden (Ludovic Courtès) writes:
>
>> "Andy Wingo" <address@hidden> skribis:
>>
>>> commit 79eb47ea47650ef42c545931726277a7118a0210
>>> Author: Andy Wingo <address@hidden>
>>> Date:   Fri Feb 24 23:05:02 2012 +0100
>>>
>>>     port i/o optimizations for iso-8859-1
>>>     
>> The problems with fast paths is that they become less fast when there
>> are many of them.
>>
>> How does this change influence ‘benchmark-suite/benchmarks/ports.bm’?
>
> Dunno, that wasn't my benchmark.  It makes the web server go faster
> (e.g. guile examples/web/debug-sxml.scm).

Can you check with that benchmark?  I think it’s important to have
concrete figures when doing such a change, to make sure the
performance/maintenance cost ratio is good.

> The reason it makes sense to optimize for this encoding is because it's
> our narrow encoding.

I don’t see how Guile’s internal representation is relevant here, since
we’re talking about input/output.

UTF-8 is used very widely out there, and that’s why I’d consider it
important to have fast UTF-8 I/O.  The same cannot be said of Latin-1.

Thanks,
Ludo’.