Re: [PATCH] Fix double-free error on non-GNU systems.

[Ludovic Courtès]

Hello!

"Chris K. Jester-Young" <address@hidden> skribis:

> * libguile/i18n.c (scm_make_locale): Null out c_locale_name after it's
>   freed, so it doesn't get freed again. While this only has effect if
>   USE_GNU_LOCALE_API is unset, the nulling out happens in both cases,
>   to be consistent and robust.

How do you reproduce the system?  I tried (make-locale LC_ALL "sdf") on
FreeBSD, and I don’t see any problems (it could be that the double-free
is silently ignored, though.)

If you find a case that reproducibly leads to a crash, it would be nice
to add it to i18n.test.

>   (scm_nl_langinfo): Free c_result in all switch cases, in particular
>   P_SIGN_POSN, N_SIGN_POSN, INT_P_SIGN_POSN, and INT_N_SIGN_POSN.

Indeed.

Thanks for catching those, and feel free to commit!

Ludo’.