Re: [PATCH] Universally-unique gensyms

[Andy Wingo]

On Wed 18 Jan 2012 22:41, address@hidden (Ludovic Courtès) writes:

> Could you stick to GNU-style change logs, describing the change (for
> example, “New function”), and not the rationale, function, etc.?
>
> (Andy might disagree with me, but don’t listen to him. ;-))

FWIW I have grown to agree with you over time, and your chiding, while
not always well-received in the moment, has made for better commit logs
:)

>> +  static const char base64[GENSYM_RADIX] =
>> +    "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789$@";
>> +  static const char base4[4] = "_.-~";
>
> Could we use Gnulib’s ‘base64’ module instead?

FWIW (again) I thought the same initially, but Mark is incrementing a
base64 buffer instead of continually reencoding a value.  It seems OK in
this instance.

>> +  /* Thread-local gensym counter.
>> +   */
>> +  unsigned char *gensym_counter;
>
> Apparently this doesn’t break the ABI, right?

Interesting.

Sorry for asking a stupid question, but why is it that we want the
gensym counter to be thread-local?  Just to avoid the mutex?  TBH I
don't think it's that big of a point of contention.  This risks
devolution into bike-shed-landia tho...

Regards

Andy
-- 
http://wingolog.org/