guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Set the FD_CLOEXEC flag on the runtime's file descriptors


From: Andy Wingo
Subject: Re: [PATCH] Set the FD_CLOEXEC flag on the runtime's file descriptors
Date: Thu, 16 Jun 2011 19:50:21 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Hi,

Sorry for the long delay here.

On Sun 08 May 2011 00:29, Andreas Rottmann <address@hidden> writes:

> * libguile/_scm.h (scm_set_fd_cloexec): New convenience macro for
>   setting the FD_CLOEXEC flah on platforms that support it; on other
>   platforms it's a no-op.

This isn't the right fix, I don't think.  I think the right thing is to
use open with O_CLOEXEC in objcodes.c (possibly with the open gnulib
module) and pipe2 with O_CLOEXEC in scmsigs.c and threads.c (possibly
with the pipe2 gnulib module).  I've done that in HEAD now.  Thanks for
the motivation!

Andy
-- 
http://wingolog.org/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]