Re: [PATCH] Fix the R6RS exact-integer-sqrt and import into core guile

[Mark H Weaver]

address@hidden (Ludovic Courtès) writes:
>> I'd like to push this to stable-2.0.  Any objections?
>
> Not from me!

Excellent! :)

> One remark:
>
>> --- a/libguile/numbers.h
>> +++ b/libguile/numbers.h
>> @@ -289,6 +289,7 @@ SCM_API SCM scm_log (SCM z);
>>  SCM_API SCM scm_log10 (SCM z);
>>  SCM_API SCM scm_exp (SCM z);
>>  SCM_API SCM scm_sqrt (SCM z);
>> +SCM_API void scm_exact_integer_sqrt (SCM k, SCM *s, SCM *r);
>
> Shouldn’t it be SCM_INTERNAL?  (If yes, then the doc should use @deffn
> instead of @deftypefn.)

Why do you think the C interface should be kept internal?  Most of the
core arithmetic procedures provide public C interfaces.  Why should
exact-integer-sqrt be treated differently?

    Mark