guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add `fixnum?' VM primitive


From: Andy Wingo
Subject: Re: [PATCH] Add `fixnum?' VM primitive
Date: Tue, 29 Mar 2011 12:52:09 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

On Fri 25 Mar 2011 00:51, Andreas Rottmann <address@hidden> writes:

>> For ‘master’ your patch looks good to me modulo a few details.  Why did
>> you need to renumber VM opcodes? 
>>
> I didn't need to do so, but the neat order elicited my instinct to keep
> it ;-).  I'll revert that part; should I then put `fixnum?' at the
> end?

You can leave it where it is, if you wanted, and just give it a later
number.  Then when we renumber in 2.2, it will get a number in the
"neat" order.

All of those definitions expand out to `case' blocks, but I don't know
what the compiler does with them.  Does it actually put them in the
order they appear?  Does it put them in numerical order?  I do know that
it puts the UNLIKELY blocks at the end of the VM engine, which is
important, but I don't know what it does with instructions for the
various opcodes.

Andy
-- 
http://wingolog.org/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]