[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] First batch of numerics changes
From: |
Andy Wingo |
Subject: |
Re: [PATCH] First batch of numerics changes |
Date: |
Sun, 30 Jan 2011 13:12:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
On Sat 29 Jan 2011 09:20, Mark H Weaver <address@hidden> writes:
> @@ -728,7 +728,7 @@ SCM_PRIMITIVE_GENERIC (scm_abs, "abs", 1, 0, 0,
> "Return the absolute value of @var{x}.")
> #define FUNC_NAME
> {
> - if (SCM_I_INUMP (x))
> + if (SCM_LIKELY (SCM_I_INUMP (x)))
> {
> scm_t_inum xx = SCM_I_INUM (x);
> if (xx >= 0)
Is this really likely the case? Probably not. I'm going to hold off on
this patch, unless you really want it in.
I applied the other four in your series, though not including the div0
one.
Thanks for the patches!
Andy
--
http://wingolog.org/
- Re: [PATCH] First batch of numerics changes, (continued)
- Re: [PATCH] First batch of numerics changes, Andy Wingo, 2011/01/28
- Re: [PATCH] First batch of numerics changes, Mark H Weaver, 2011/01/29
- Re: [PATCH] First batch of numerics changes, Andy Wingo, 2011/01/29
- Re: [PATCH] First batch of numerics changes, Mark H Weaver, 2011/01/29
- Re: [PATCH] First batch of numerics changes, Andy Wingo, 2011/01/30
- Re: [PATCH] First batch of numerics changes, Andy Wingo, 2011/01/29
- Re: [PATCH] First batch of numerics changes, Mark H Weaver, 2011/01/29
- Re: [PATCH] First batch of numerics changes, Mark H Weaver, 2011/01/29
- Commentary: R6RS div0-and-mod0 vs Taylor's `round/', Mark H Weaver, 2011/01/30
- Re: [PATCH] First batch of numerics changes, Andy Wingo, 2011/01/30
- Re: [PATCH] First batch of numerics changes,
Andy Wingo <=
- Re: [PATCH] First batch of numerics changes, Mark H Weaver, 2011/01/30
Re: [PATCH] First batch of numerics changes, Andy Wingo, 2011/01/28