guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Sputnik test result


From: Noah Lavine
Subject: Re: Sputnik test result
Date: Thu, 27 Jan 2011 11:12:58 -0500

Hi all,

When I was looking at this a while ago, it looked like a big issue
(possibly *the* big issue) with Guile's parser is that it doesn't do
automatic semicolon insertion. (In Javascript, semicolons are optional
in certain contexts, when the place where the semicolon would be is
followed by a newline.)

Unfortunately, dealing with semicolon insertion is sort of a pain. I
was really hoping to find a way to get the tokenizer to deal with it,
and possibly there is one. But if there's not, we would have to make
newlines into tokens, and then put them into the grammar at all places
where newlines are allowed, and then use that to make semicolons
optional in the right places.

Noah

On Thu, Jan 27, 2011 at 11:08 AM, Andy Wingo <address@hidden> wrote:
> Hi Kan-Ru,
>
> On Tue 04 Jan 2011 10:23, Kan-Ru Chen <address@hidden> writes:
>
>> I ran the sputniktests[1] from google using the attached guile-es-parse
>> script, which only tests the parser.
>>
>>   === Summary ===
>>    - Ran 5246 tests
>>    - Passed 4410 tests (84.1%)
>>    - Failed 836 tests (15.9%)
>
> Excellent test case!  I just ran the tests again, with the recent
> patches, and we have:
>
> === Summary ===
>  - Ran 5246 tests
>  - Passed 4655 tests (88.7%)
>  - Failed 591 tests (11.3%)
>
> So an improvement, but still quite a ways to go.  I think the ones that
> were fixed are the unicode errors that you mentioned:
>
>> Where the failed tests have
>>
>>    - 245 unicode errors (unicode literal is not supported)
>>    - 393 rbrace errors  (see below)
>>    - 39 Math.LN2 errors (see below)
>>    - 159 remain to sort out
>
> So we are left with the rest of them to sort out.  Then of course to
> actually compile them, eh...
>
> Andy
> --
> http://wingolog.org/
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]