guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Some tweaks to the R6RS support


From: Andreas Rottmann
Subject: Re: [PATCH] Some tweaks to the R6RS support
Date: Sat, 20 Nov 2010 19:09:16 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Andy Wingo <address@hidden> writes:

> Hi Andreas,
>
> On Wed 27 Oct 2010 00:53, Andreas Rottmann <address@hidden> writes:
>
>> * module/rnrs/base.scm (error, assert): Define -- they were missing.
>>   (assertion-violation): Properly treat a #f `who' argument.
>>
>> * module/rnrs/conditions.scm (condition): Use `assertion-violation'
>>   instead of the undefined `raise'.
>>   (define-condition-type): Fix for multiple fields.
>> * test-suite/tests/r6rs-conditions.test: Test accessors of a
>>   multiple-field condition.  Also import `(rnrs base)' to allow
>>   stand-alone running of the tests; apparently the `@' references
>>   scattered throughout the R6RS modules make the libraries sensitive to
>>   their load order -- for instance, trying to load `(rnrs conditions)'
>>   before `(rnrs base)' is loaded fails.
>>
>> * module/rnrs/records/inspection.scm: Use `assertion-violation' instead
>>   of an explicit `raise'.
>> * module/rnrs/records/syntactic.scm (process-fields): Use
>>   `syntax-violation' instead of bogus invocations of `error'.
>
> This patch no longer applies. Apologies for the delay. Can you take a
> look at which parts are still valid?
>
It seems all of it is still relevant; I've attached a refreshed patch,
which should apply cleanly.

Attachment: rnrs-tweaks.diff
Description: Text Data

Cheers, Rotty
-- 
Andreas Rottmann -- <http://rotty.yi.org/>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]