guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]


From: Ludovic Courtès
Subject: Re: [PATCH]
Date: Thu, 28 Oct 2010 00:14:39 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Hi Neil,

Neil Jerram <address@hidden> writes:

> I have a program that calls (read-elisp) in a loop, to read in a BBDB
> file.  When it gets to the end of the file, the next (read-elisp) throws
> an error (wrong type arg, pair expected), and the attached patch makes
> it return '*eoi* instead.
>
> Is that correct?

‘get-lexer/1’ can return '*eoi*, so yes, I think.

> Is *eoi* better than #<eof> here?

I don’t think so, since it’s the result returned by ‘read-elisp’, whose
callers shouldn’t see '*eoi*.  So I think ‘get-expression’ should return
the EOF object when it encounters '*eoi*.

Besides, you might want to check if it’s fixed in the elisp branch, who
knows.  :-)

Thanks,
Ludo’.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]