guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Andy Wingo] Re: [PATCH] Fix for `submodules' in (ice-9 session) (closes


From: Andy Wingo
Subject: [Andy Wingo] Re: [PATCH] Fix for `submodules' in (ice-9 session) (closes #30062)
Date: Thu, 02 Sep 2010 22:27:04 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

--- Begin Message --- Subject: Re: [PATCH] Fix for `submodules' in (ice-9 session) (closes #30062) Date: Thu, 02 Sep 2010 22:01:16 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
Hi,

Sorry for the delay. The reason I was holding off was because my
backwards-compatibility shims should have been working, but they
weren't, and so I wanted to commit the fix to the back-compat shims,
then have your test-case go in (to verify back-compatibility), then have
your fix to the submodules function go in (to avoid using deprecated
features).

Specifically I wanted to test that one could resolve modules via the
value namespace only in Guile 2.0. Your fix is needed regardless to
work with Guile built without support for deprecated code.

I have now pushed my back-compat fix, then applied your
patch. Everything is working fine, and I have pushed.

However why does adding the test:

  (pass-if "a leaf module: ice-9 q" (find-mod-name '(ice-9 q)))

Why does that fail? Is it because ice-9 q is not loaded? 

Thanks for the patch, and the debugging, and for putting up with the
back-and-forth :)

Cheers,

Andy
-- 
http://wingolog.org/

--- End Message ---

-- 
http://wingolog.org/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]