Re: [PATCH] Support for SRFI 27

[Andy Wingo]

On Sun 15 Aug 2010 07:57, address@hidden (Ludovic Courtès) writes:

> Hello!
>
> Andreas Rottmann <address@hidden> writes:
>
>> Attached is my take on adding SRFI 27 "Sources of Random Bits".
>
> Nice!  Looks good to me.  Could you also add a node to
> doc/ref/srfi-modules.texi?

Yes, looks quite good to me!

Just a friendly ping to write some docs :)

>> +;; These tests are commented out since it /could/ happen that
>> +;; `random-source-randomize!' (or `random-source-pseudo-randomize!') puts 
>> the
>> +;; RNG into a state where it generates the same number as before. If you run
>> +;; them manually, they should have a very high chance of passing, though.
>
> Perhaps you could run them anyway and throw 'unresolved when they appear
> to fail?  The guardian tests do that when it’s impossible to determine
> whether it’s a failure or whether some unrelated phenomenon prevented
> the test to pass.

Agreed.

Cheers,

Andy
-- 
http://wingolog.org/