Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-8-23-gea6b18e

[Andy Wingo]

Heya,

On Sun 28 Feb 2010 22:31, address@hidden (Ludovic Courtès) writes:

> (Sorry for the late & light review...)

Sorry for the late & light reply :)

>> +#define SCM_I_FLUID_P(x)          (!SCM_IMP (x) && SCM_TYP7 (x) == 
>> scm_tc7_fluid)
>
> How about renaming it to ‘SCM_FLUID_P’ and making it public?

Done

>> +#define SCM_I_FLUID_NUM(x)        ((size_t)SCM_CELL_WORD_1(x))
>
> Could be in #ifdef BUILDING_LIBGUILE?

Done

>> diff --git a/libguile/vm-engine.c b/libguile/vm-engine.c
>> index 75dd613..5d1e1d6 100644
>> --- a/libguile/vm-engine.c
>> +++ b/libguile/vm-engine.c
>> @@ -47,6 +47,7 @@ VM_NAME (SCM vm, SCM program, SCM *argv, int nargs)
>>    SCM *objects = NULL;                      /* constant objects */
>>    size_t object_count = 0;              /* length of OBJECTS */
>>    SCM *stack_limit = vp->stack_limit;       /* stack limit address */
>> +  SCM dynstate = SCM_I_CURRENT_THREAD->dynamic_state;
>
> Out of curiosity, what effect does this have on performance?

Dunno!

>> +  (<dynref> fluid)
>> +  (<dynset> fluid exp)
>
> At first sight ‘fluid-ref’ and ‘fluid-set’ would seem more natural names
> to me.  What do you think?

I had it like that before, but I did it this way to match dynwind and dynlet.

Andy
-- 
http://wingolog.org/