[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Fix hanging of popen.test
From: |
Neil Jerram |
Subject: |
[PATCH] Fix hanging of popen.test |
Date: |
Thu, 10 Jun 2010 23:54:56 +0100 |
The "open-output-pipe":"no duplicate" test has been hanging, on and
off, and not completely reliably, for a few years. It's now doing so
fairly reliably for me, and investigation shows that
- the child shell process is in a tight loop (99% CPU)
- the parent Guile process is stuck calling waitpid().
The problem is that the child hasn't got the SIGPIPE that the test
intends, and so is continuing to echo "closed" forever; and Guile is
waiting for it to terminate, forever.
I haven't fully debugged the SIGPIPE problem, but it sounds very like
what Chet Ramey describes here:
http://old.nabble.com/Re%3A-SIGPIPE-not-properly-reset-with-%27trap---PIPE%27-p20985595.html.
(And my version of bash is 3.2.39.)
So, a fix should be to use something other than shell to implement the
child; and it appears that this works.
* check-guile.in (TEST_SUITE_DIR): Export.
* test-suite/tests/popen-child.scm: New script file.
* test-suite/tests/popen.test ("open-output-pipe", "no duplicate"):
Use Guile for the child process, instead of shell.
---
check-guile.in | 1 +
test-suite/tests/popen-child.scm | 4 ++++
test-suite/tests/popen.test | 5 +++--
3 files changed, 8 insertions(+), 2 deletions(-)
create mode 100644 test-suite/tests/popen-child.scm
diff --git a/check-guile.in b/check-guile.in
index dde51b3..fc670e1 100644
--- a/check-guile.in
+++ b/check-guile.in
@@ -15,6 +15,7 @@ address@hidden@
address@hidden@
TEST_SUITE_DIR=${top_srcdir}/test-suite
+export TEST_SUITE_DIR
if [ x"$1" = x-i ] ; then
guile=$2
diff --git a/test-suite/tests/popen-child.scm b/test-suite/tests/popen-child.scm
new file mode 100644
index 0000000..4bfe6b7
--- /dev/null
+++ b/test-suite/tests/popen-child.scm
@@ -0,0 +1,4 @@
+(close-port (current-input-port))
+(let loop ()
+ (display "closed\n" (current-error-port))
+ (force-output (current-error-port)))
diff --git a/test-suite/tests/popen.test b/test-suite/tests/popen.test
index 0a20cff..a408c9e 100644
--- a/test-suite/tests/popen.test
+++ b/test-suite/tests/popen.test
@@ -167,8 +167,9 @@
(let* ((c2p (pipe))
(port (with-error-to-port (cdr c2p)
(lambda ()
- (open-output-pipe
- "exec 0</dev/null; while true; do echo closed 1>&2;
done")))))
+ (open-output-pipe (format #f
+ "guile -s
~a/tests/popen-child.scm"
+ (getenv "TEST_SUITE_DIR")))))))
(close-port (cdr c2p)) ;; write side
(with-epipe
(lambda ()
--
1.7.1
- [PATCH] Fix hanging of popen.test,
Neil Jerram <=
- Re: [PATCH] Fix hanging of popen.test, Neil Jerram, 2010/06/11
- Re: [PATCH] Fix hanging of popen.test, Andy Wingo, 2010/06/14
- Re: [PATCH] Fix hanging of popen.test, Neil Jerram, 2010/06/28
- Re: [PATCH] Fix hanging of popen.test, Andy Wingo, 2010/06/29
- Re: [PATCH] Fix hanging of popen.test, Neil Jerram, 2010/06/29
- Re: [PATCH] Fix hanging of popen.test, Neil Jerram, 2010/06/30
- Re: [PATCH] Fix hanging of popen.test, Neil Jerram, 2010/06/30