[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Merging ‘bdw-gc-static-alloc’
From: |
Ludovic Courtès |
Subject: |
Re: Merging ‘bdw-gc-static-alloc’ |
Date: |
Fri, 23 Oct 2009 11:16:37 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Hi,
Andy Wingo <address@hidden> writes:
> On Fri 02 Oct 2009 02:15, address@hidden (Ludovic Courtès) writes:
>
>> Because of the macrology that’s used to statically allocate stringbufs [0],
>> the string has to be a literal:
>>
>> SCM_SYMBOL (s_foo, "foo");
>>
>> What do you think?
>
> Need more information :) How widespread is the non-literal usage? Could
> you grep the source packages of the Guile users that you have identified
> for occurrences of this idiom?
Apparently this is going to be rare. I’ve found no occurrences here:
http://www.google.fr/codesearch?q=SCM_%28GLOBAL_%29%3FSYMBOL&hl=fr&btnG=Rechercher+du+code
“grep -r -E \
'SCM_(GLOBAL_)?SYMBOL[[:blank:]]*\([^,]+,[[:blank:]]*[^"]+\)' \
gnucash-2.2.9 guile-avahi guile-cairo-1.4.0 \
guile-gnome-platform-2.16.1 gnutls mailutils-2.1 snd-9.4”
doesn’t show any occurrence either.
So I’d be tempted to merge this in.
What do you think?
Ludo’.