Re: Some leftover bugs for this release

[Ludovic Courtès]

Hi Mike,

Mike Gran <address@hidden> writes:

>> > Also, the netbsd build will likely fail because there is new
>> > 'condition is always true' condition in array-handle.c:103
>> >
>> > 100 SCM
>> > 101 scm_array_handle_element_type (scm_t_array_handle *h)
>> > 102 {
>> > 103 
>>   if (h->element_type < 0 || h->element_type > SCM_ARRAY_ELEMENT_TYPE_LAST)
>> > 104     abort (); /* guile programming error */
>> > 105   return scm_i_array_element_types[h->element_type];
>> > 106 }
>> 
>> Hmm, an enum variable can possibly hold any integer value, so why would
>> this always be true?  Are you actually hitting this?

[...]

> So when I enable -Wtype-limits on my build, it warns for any enum
> value that is beyond those enumerated in the type definition.  The 
> smallest value in this enum is zero, hence the warning.

Then we could just use ‘-Wtype-limits’ and remove the above run-time
check.  Andy?

Thanks,
Ludo’.