guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GNU Guile 1.9.0 released (alpha)


From: Neil Jerram
Subject: Re: GNU Guile 1.9.0 released (alpha)
Date: Sun, 21 Jun 2009 13:36:03 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

Andy Wingo <address@hidden> writes:

> Hi Mike,
>
> On Sun 21 Jun 2009 08:31, Mike Gran <address@hidden> writes:
>
>> Not really in a position to help, since I'm still AFK, but, 
>> somewhere along the line I pushed this patch to r6rs vectors
>> in the String_abstraction2 tree.
>
> Took me a little while to understand it, but it seems the patch is
> right. I committed and pushed it to master. Linas, can you try again?
>
> Thanks much!

I've pushed a deterministic test for this (also below).  (In general,
when fixing something that isn't already reliably reproduced by the
build, please write a regression test if feasible.)

      Neil

>From 4574ec212aad4df9571463ee4d45beb2607e51ad Mon Sep 17 00:00:00 2001
From: Neil Jerram <address@hidden>
Date: Sun, 21 Jun 2009 13:31:20 +0100
Subject: [PATCH] Deterministic test for the r6rs-ports.test segmentation fault

* test-suite/tests/r6rs-ports.test ("7.2.7 Input Ports"): Add (gc), to
  test the (ex-)bug in cbp_mark () when marking a closed port.
---
 test-suite/tests/r6rs-ports.test |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/test-suite/tests/r6rs-ports.test b/test-suite/tests/r6rs-ports.test
index 829258f..df12e5c 100644
--- a/test-suite/tests/r6rs-ports.test
+++ b/test-suite/tests/r6rs-ports.test
@@ -342,6 +342,7 @@
                                                     close!)))
 
       (close-port port)
+      (gc) ; Test for marking a closed port.
       closed?)))
 
 
-- 
1.5.6.5


reply via email to

[Prev in Thread] Current Thread [Next in Thread]