[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Guile-commits] GNU Guile branch, master, updated. 442f3f20ddd33b437
From: |
Ludovic Courtès |
Subject: |
Re: [Guile-commits] GNU Guile branch, master, updated. 442f3f20ddd33b43743ea181d95024c10622df52 |
Date: |
Tue, 26 May 2009 19:10:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) |
Hello!
Thanks for working on this!
"Andy Wingo" <address@hidden> writes:
> +#if BUILDING_LIBGUILE && HAVE_VISIBILITY
> +# define SCM_API extern __attribute__((__visibility__("default")))
> +#elif BUILDING_LIBGUILE && defined _MSC_VER
This should be:
#if defined BUILDING_LIBGUILE && BUILDING_LIBGUILE && HAVE_VISIBILITY
...
Also, I'd have preferred `_GUILE_WITHIN_GUILE', which is clearly in
Guile's name space, and is similar to GMP's `__GMP_WITHIN_GMP' ("rule of
least surprise"). What do you think?
Thanks,
Ludo'.
- Re: [Guile-commits] GNU Guile branch, master, updated. 442f3f20ddd33b43743ea181d95024c10622df52,
Ludovic Courtès <=