Re: Guile 1.8 success on `i386-apple-darwin9.6.0'

[Neil Jerram]

address@hidden (Ludovic Courtès) writes:

> Good morning!

Hello again!

>> Just one nit: I think there's now only 1 piece of Automake magic being
>> relied on, so you could update that text (in Makefile.am) and remove
>> the "2. ".
>
> Right, I did this:
>
>   
> http://git.savannah.gnu.org/cgit/guile.git/commit/?id=0fe95f9c4ce063781e79a15bc123c57c33ef9755

Thanks, that looks good.

> So IIUC you're advocating the creation of 88 new header files, right?

Potentially, yes. :-)

> I think I'd prefer the single-private-header option, but I'm not 100%
> convinced either.
>
> Actually there's yet another option: enclose internal declarations in
> "#ifdef LIBGUILE_IN_LIBGUILE" or similar, which we only define when
> compiling Guile itself.  This is what Glibc does with, e.g.,
> `__LIBC_INTERNAL_MATH_INLINES' and what GMP does with
> `__GMP_WITHIN_GMP'.  I think I like it better.

That sounds fine to me too - so I guess we should choose this
approach.  Although I would find "LIBGUILE_INTERNAL" more intuitive
than "LIBGUILE_IN_LIBGUILE".

Regards,
        Neil