guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: _GNU_SOURCE redundant define


From: Greg Troxel
Subject: Re: _GNU_SOURCE redundant define
Date: Fri, 15 Aug 2008 09:32:50 -0400
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.1 (berkeley-unix)

Greg Troxel <address@hidden> writes:

> On NetBSD-current/amd64, the branch_release-1-8 branch fails to build.
> _GNU_SOURCE is defined in config.h, and also in two files.  With the
> following change, it builds and 'gmake check' succeeds.

I have figured this out.  With autoconf 2.62 on NetBSD, several macros
end up defining _GNU_SOURCE.  The following diff makes guile build for
me (plus enables autobuild).  I'm not sure what the right fix is; it
seems broken for AC_AIX to define _GNU_SOURCE at all, especially on
NetBSD.  I'd be somewhat inclined to drop the three macros, and have
adherents of AIX, ISC_POSIX, and MINIX find another way around if
needed.

Alternatively, the two _GNU_SOURCE defines could be wrapped in ifndef
_GNU_SOURCE.

Also, I noticed a forced define of _GNU_SOURCE inside the strptime test.
The NetBSD man page says:

  STANDARDS
       The strptime() function conforms to X/Open Portability Guide Issue 4
       (``XPG4'').

so it would seem that shouldn't be necessary.


diff --git a/configure.in b/configure.in
index ee3d527..101de10 100644
--- a/configure.in
+++ b/configure.in
@@ -49,6 +49,9 @@ AC_CONFIG_SRCDIR([GUILE-VERSION])
 
 AM_MAINTAINER_MODE
 AC_CONFIG_HEADERS([config.h])
+
+AB_INIT
+
 AH_TOP(/*GUILE_CONFIGURE_COPYRIGHT*/)
 
 #--------------------------------------------------------------------
@@ -73,10 +76,14 @@ AC_PROG_CC
 AC_PROG_CPP
 AC_PROG_AWK
 
-AC_AIX
-AC_ISC_POSIX
-AC_MINIX
+# AC_AIX
+dnl AC_AIX
+# AC_ISC_POSIX
+dnl AC_ISC_POSIX
+# AC_MINIX
+dnl AC_MINIX
 
+# c89
 AC_PROG_CC_C89
 
 # for per-target cflags in the libguile subdir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]