Re: [patch] subordinate SMOBs with GOOPS superclasses

[Andy Wingo]

Hi Marco,

What follows is a review by an ignorant individual!

On Tue 27 Nov 2007 07:57, "Marco Maggi" <address@hidden> writes:

> The attached patch documents the creation of
> a GOOPS class whenever a new SMOB type is
> defined and GOOPS has been already loaded.

Excellent! Would be nice if the mime type of your patch were noted as
text. Anyway, this behavior is confusing, and it's nice that you're
documenting it.

+If GOOPS is loaded when @code{scm_make_smob_type} is invoked: a new

You probably wanted a comma there.

+A special smob type is implemented to overcome the 255 limit on the
+number of smob types. Its procedures dispatch the call to procedures
+referenced by a subsmob descriptor.

Sounds really byzantine. The tagging system has that aspect to it, yes,
but perhaps there's a point where the complexity is too much. Why
wouldn't you use structs or something, specializing allocate-instance in
GOOPS to give you some kind of structure that can hold a variable number
of raw machine words? That's probably a better foundation for wrapping
N > 255 C types.

Anyway, just a thought.

Cheers,

Andy
-- 
http://wingolog.org/