[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix for `make-uniform-array'
From: |
Kevin Ryde |
Subject: |
Re: [PATCH] Fix for `make-uniform-array' |
Date: |
Fri, 03 Feb 2006 07:53:10 +1100 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
>
> $ ./pre-inst-guile # i.e., 1.7
> guile> (define a (make-uniform-array #\nul 10))
> ERROR: Wrong type (expecting exact integer): #\nul
> ABORT: (wrong-type-arg)
That's a bug. In 1.6 you could pass chars to array-set! (and fill)
with a #\nul (ie. byte) uniform array, that should still be possible.
(I thought I fixed something close to that another time too, before
the big srfi-4 integration. Second time lucky maybe ...)
> -(define (make-uniform-array prot . args)
> - (dimensions->uniform-array args prot))
> +(define (make-uniform-array prot . bounds)
> + (dimensions->uniform-array bounds prot prot))
Thanks, I applied that.
But if you're fixing a bug then you should make a test case which
exercises the problem, to show it's really fixed (which I guess it's
not yet fully fixed in this case), and catch it if it rears its ugly
head again.