[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Marking weak alist vectors, epilogue
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Marking weak alist vectors, epilogue |
Date: |
Tue, 10 Jan 2006 09:21:49 +0100 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) |
Neil Jerram <address@hidden> writes:
> address@hidden (Ludovic Courtès) writes:
>
>> --- orig/libguile/properties.c
>> +++ mod/libguile/properties.c
>> @@ -125,6 +125,7 @@
>> scm_init_properties ()
>> {
>> scm_properties_whash = scm_make_weak_key_hash_table (SCM_UNDEFINED);
>> + scm_properties_whash = scm_permanent_object (scm_properties_whash);
>> #include "libguile/properties.x"
>> }
>
> What is the symptom of the fact that we are currently missing this
> line?
You mean: does it actually yield a fault at run-time? Well, it doesn't
/seem/ to (i.e., I haven't identified any reproducible "bug" caused by
this), but I think it /could/. ;-)
All other such global variables are, understandably, explicitly made
non-collectable. For instance, in `srcprop.c', SCM_SOURCE_WHASH is
non-collectable because it is bound to a top-level binding. In
`symbols.c', the SYMBOLS weak hash table is made permanent via a call to
`scm_permanent_object ()'.
Thanks,
Ludovic.