guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 64-bit initial fix is now in cvs.


From: Dirk Herrmann
Subject: Re: 64-bit initial fix is now in cvs.
Date: Mon, 8 Oct 2001 23:42:46 +0200 (MEST)

On Fri, 21 Sep 2001, Rob Browning wrote:

>   1) What is now the correct type for C-side string lengths, size_t?

Yes, we have decided to use size_t as the external representation for
string lengths.

>   2) In strings.h, in SCM_SET_STRING_LENGTH, I temporarily coerced "l"
>      to a long, but I presume it should be coerced to whatever the
>      answer is above.

Well, not quite:  SCM_SET_STRING_LENGTH will store the length in a
scm_t_bits variable, thus the length should IMO be coerced to scm_t_bits
value.  This is the internal representation, which may change.

>   3) In numbers.c, in scm_gcd, I changed "k" from an int to a long.
>      Someone more familiar with that code might want to double check
>      to make sure that's right.

Looks OK, but I am not sure I am actually more familiar with the code :-)

Best regards
Dirk Herrmann




reply via email to

[Prev in Thread] Current Thread [Next in Thread]