Re: Fixing num2integral.i.c's warnings (a proposal).

[Marius Vollmer]

Rob Browning <address@hidden> writes:

> Since the compiler can't compute sizeof(X) at compile time

It can't?

> I propose we fix up configure to generate a set of variables of the
> form GUILE_SIZEOF_FOO where FOO is one of the itypes, and also a
> variable named GUILE_SIZEOF_SCM_T_SIGNED_BITS (feel free to suggest
> other names, though these don't need to be public).
> 
> Then INTEGRAL2NUM can be rewritten to conditionally compile code based
> on a test like this
> 
>   #if GUILE_SIZEOF_ITYPE < GUILE_SIZEOF_SCM_T_SIGNED_BITS
>     ...

Hmm, I think this is what I did, effectively, but gratuitously
incompatible to your proposal (because I hadn't re-read it before
doing the fix...)

One additional problem was that the preprocessor didn't want to work
with long long constants like "1LL".