[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: New NUM2INTEGRAL functions - unwanted polymorphism?
From: |
Mikael Djurfeldt |
Subject: |
Re: New NUM2INTEGRAL functions - unwanted polymorphism? |
Date: |
22 Sep 2001 23:19:35 +0200 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 |
Rob Browning <address@hidden> writes:
> Mikael Djurfeldt <address@hidden> writes:
>
> > OK, removed.
> >
> > And I added a message about missing the inexact in the 1.6 release due
> > to the changed behavior, as you suggested.
> >
> > For 1.7 I removed the clause completely. If we later decide to give
> > this kind of hint about what is expected, we should do it for all
> > functions and all types.
>
> I tried a make check, and it fails in srfi-19.
>
> ERROR: srfi-19.test: SRFI date/time library: #<procedure julian-day->date
> (jdn . tz-offset)> respects local DST if no TZ-OFFSET given - arguments:
> ((wrong-type-arg "localtime" "Wrong type (inexact) argument in position ~A:
> ~S" (1 991396800.0) #f))
> ERROR: srfi-19.test: SRFI date/time library: #<procedure
> modified-julian-day->date (jdn . tz-offset)> respects local DST if no
> TZ-OFFSET given - arguments: ((wrong-type-arg "localtime" "Wrong type
> (inexact) argument in position ~A: ~S" (1 991396800.0) #f))
>
> I suppose some of the math may be wrong in there. I'll look in to it
> when I get a chance, unless someone else beats me to it.
It was a missing inexact->exact in srfi-19.scm:priv:split-real.
Fixed now.
Thanks,
/mdj