[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: Include grub-core/extra_deps.lst in dist
From: |
Daniel Kiper |
Subject: |
Re: [PATCH] build: Include grub-core/extra_deps.lst in dist |
Date: |
Fri, 22 Dec 2023 15:23:13 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, Dec 22, 2023 at 12:45:53AM -0600, Oskari Pirhonen wrote:
> On Thu, Dec 21, 2023 at 03:07:16 -0800, Oliver Steffen wrote:
> > Quoting Olaf Hering (2023-12-21 11:50:49)
> > > Thu, 21 Dec 2023 02:42:46 -0800 Oliver Steffen <osteffen@redhat.com>:
> > >
> > > > Although its name suggests that it is a generated file (.lst ending!),
> > > > extra_deps.lst is actually tracked in git and is not generated by the
> > > > build system.
> > >
> > > I think a simple "echo 'content' > extra_deps.lst" in a Makefile would do.
> > >
> > I am fine with getting rid of this file. My intention was to track the
> > module dependencies in an obviuos place and not lose it in one of the
> > endless Makefiles.
>
> I wonder if adding machinery which allows you to explicitly declare
> module dependencies in Makefile.core.def would be the best move going
> forward.
I am not convinced this potential machinery will be used often but if
somebody is willing to make it I am OK with reviewing patches.
Daniel
Re: [PATCH] build: Include grub-core/extra_deps.lst in dist, Oliver Steffen, 2023/12/21
Re: [PATCH] build: Include grub-core/extra_deps.lst in dist, Daniel Kiper, 2023/12/22