[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 18/20] cryptodisk: Fallback to passphrase
From: |
Gary Lin |
Subject: |
[PATCH v7 18/20] cryptodisk: Fallback to passphrase |
Date: |
Mon, 20 Nov 2023 15:16:42 +0800 |
From: Patrick Colp <patrick.colp@oracle.com>
If a protector is specified, but it fails to unlock the disk, fall back
to asking for the passphrase. However, an error was set indicating that
the protector(s) failed. Later code (e.g., LUKS code) fails as
`grub_errno` is now set. Print the existing errors out first, before
proceeding with the passphrase.
Signed-off-by: Patrick Colp <patrick.colp@oracle.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
grub-core/disk/cryptodisk.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
index dba5efa61..bbb9a56b5 100644
--- a/grub-core/disk/cryptodisk.c
+++ b/grub-core/disk/cryptodisk.c
@@ -1191,11 +1191,16 @@ grub_cryptodisk_scan_device_real (const char *name,
source->name, source->partition != NULL ? "," : "",
part != NULL ? part : N_("UNKNOWN"), dev->uuid);
grub_free (part);
- goto error;
}
if (!cargs->key_len)
{
+ if (grub_errno)
+ {
+ grub_print_error ();
+ grub_errno = GRUB_ERR_NONE;
+ }
+
/* Get the passphrase from the user, if no key data. */
askpass = 1;
part = grub_partition_get_name (source->partition);
--
2.35.3
- [PATCH v7 08/20] protectors: Add key protectors framework, (continued)
- [PATCH v7 08/20] protectors: Add key protectors framework, Gary Lin, 2023/11/20
- [PATCH v7 09/20] tpm2: Add TPM Software Stack (TSS), Gary Lin, 2023/11/20
- [PATCH v7 10/20] protectors: Add TPM2 Key Protector, Gary Lin, 2023/11/20
- [PATCH v7 11/20] cryptodisk: Support key protectors, Gary Lin, 2023/11/20
- [PATCH v7 12/20] util/grub-protect: Add new tool, Gary Lin, 2023/11/20
- [PATCH v7 13/20] tpm2: Add TPM2 types, structures, and command constants, Gary Lin, 2023/11/20
- [PATCH v7 14/20] tpm2: Add more marshal/unmarshal functions, Gary Lin, 2023/11/20
- [PATCH v7 16/20] tpm2: Support authorized policy, Gary Lin, 2023/11/20
- [PATCH v7 15/20] tpm2: Implement more TPM2 commands, Gary Lin, 2023/11/20
- [PATCH v7 17/20] protectors: Implement NV index, Gary Lin, 2023/11/20
- [PATCH v7 18/20] cryptodisk: Fallback to passphrase,
Gary Lin <=
- [PATCH v7 19/20] cryptodisk: wipe out the cached keys from protectors, Gary Lin, 2023/11/20
- [PATCH v7 20/20] diskfilter: look up cryptodisk devices first, Gary Lin, 2023/11/20