Re: [PATCH 0/2] Bli: fix hidden module dependency

[Oliver Steffen]

Quoting Vladimir 'phcoder' Serbinenko (2023-11-14 19:21:49)
> In general series looks good. Few comments:
> * I'm unsure about the name. It seems to suggest that people put the
> dependencies there by default while in fact it's the last place for it. Maybe
> extra_deps.lst?
>
Sounds good to me.

Are we ok with the '.lst' extension? Files of this type are listed in
.gitignore and this would be an exception.

> * EFI supports both GPT and msdos. GPT is a more common choice but I still
> think that a dependency on part_msdos is warranted

bli does not make use of msdos partitions. It ignores them.

bli implements a small part of the Boot Loader Interface spec [1], by
setting some EFI variables that are later consumed by systemd. One of
them contains the GPT UUID of the ESP/the partition used during boot.
This is needed to make systemd's partition autodetection work [2,3]. All
of this is build around GPT and uses the UUIDs of GPTm and does not work
with msdos formatted disks.

[1] https://systemd.io/BOOT_LOADER_INTERFACE/
[2] 
https://www.freedesktop.org/software/systemd/man/systemd-gpt-auto-generator.html
[3] 
https://uapi-group.org/specifications/specs/discoverable_partitions_specification

> * Please elaborate commit message as to why bli needs those mods rather than
> "not functions properly". Detail that it needs to identify partitions.

I can do that.
bli tries to read the UUID of the ESP/the partition Grub was loaded
from. If that is not GPT or otherwise not reachable, then it does not
set the corresponding EFI variable, but c

> Le mar. 14 nov. 2023, 17:45, Oliver Steffen <osteffen@redhat.com> a écrit :
>
>     The bli module has a hidden/implicit dependency on the part_gpt module.
>     The part_gpt module has to be loaded before the bli module.
>     This dependency is not picked up automatically by the build system
>     because the bli module does not use any function of part_gpt. It just
>     expects Grub to be able to parse GPT formatted disks.
>
>     This series introduces a mechanism that allows specifying module
>     dependencies explicitly in a new file called explicit_dependencies.lst.
>
>     An explicit dependency is then added for the bli module on the part_gpt
>     module.
>
>     Oliver Steffen (2):
>       Allow explicit module dependencies
>       bli: Add explicit dependency on the part_gpt module
>
>      grub-core/Makefile.am               | 4 ++--
>      grub-core/explicit_dependencies.lst | 1 +
>      grub-core/genmoddep.awk             | 4 ++++
>      3 files changed, 7 insertions(+), 2 deletions(-)
>      create mode 100644 grub-core/explicit_dependencies.lst
>
>     --
>     2.41.0
>
>

Thank you for the comments!

Oliver